addwin/chat
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: surface real errors when adding user to Mattermost team #11

Merged
Ghasemi merged 1 commit from feature/debug-team-member into master 2026-08-09 06:41:41 -04:00
Conversation 0 Commits 1 Files changed 1 +12 -2
ali commented 2026-08-09 06:33:39 -04:00
Collaborator
Copy link

_ensure_team_member silently swallowed every exception from
add_user_to_team, assuming failure meant the user was already a
member. Real failures (bad permissions, domain restrictions, wrong
team ID) were masked and only surfaced later as a confusing "No team
member found" error when adding the user to a channel. Now checks
actual membership via get_team_member and raises a clear
MattermostError on genuine add failures.

_ensure_team_member silently swallowed every exception from add_user_to_team, assuming failure meant the user was already a member. Real failures (bad permissions, domain restrictions, wrong team ID) were masked and only surfaced later as a confusing "No team member found" error when adding the user to a channel. Now checks actual membership via get_team_member and raises a clear MattermostError on genuine add failures.
ali added 1 commit 2026-08-09 06:33:40 -04:00 
_ensure_team_member silently swallowed every exception from
add_user_to_team, assuming failure meant the user was already a
member. Real failures (bad permissions, domain restrictions, wrong
team ID) were masked and only surfaced later as a confusing "No team
member found" error when adding the user to a channel. Now checks
actual membership via get_team_member and raises a clear
MattermostError on genuine add failures.
Ghasemi merged commit fee3a6ccb0 into master 2026-08-09 06:41:41 -04:00
Ghasemi deleted branch feature/debug-team-member 2026-08-09 06:41:41 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: addwin/chat#11
No description provided.
Delete branch "feature/debug-team-member"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?