addwin/wallet
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(wallet): adapt submit and verify process to new wallet, account concept

Browse source 
adapt submit and verify process to new wallet, account concept

test_deposit_flow_prevent_double_spending
This commit is contained in:
Haydar Ghasemi 2025-10-27 15:46:16 +03:30
parent c6b2040af9
commit 821bad13e7
2 changed files with 23 additions and 29 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
apps/wallet/tests/application.py
View file

@ -273,40 +273,37 @@ class ApplicationApiFlowsTests(APITestCase):
self.assertEqual(response.status_code, 400) self.assertEqual(response.status_code, 400)
def test_deposit_flow_prevent_double_spending(self): def test_deposit_flow_prevent_double_spending(self):
# TODO: check this test
auth = self._create_authorization_header(self.application_access_token.token) auth = self._create_authorization_header(self.application_access_token.token)
# Checking wallets initials values(application balance = 300 and payee balance = zero) # Checking wallets initials values(application balance = 300 and payee balance = zero)
response = self.client.get(reverse('wallet:application_account_balance_api'), HTTP_AUTHORIZATION=auth) wallets = [self.wallet_rial_uuid.hex, self.wallet_reward_uuid.hex]
self.assertContains(response, 'balance') response = self.client.get(reverse('wallet:application_account_balance_api'), query_params={'wallet': ','.join(wallets)}, HTTP_AUTHORIZATION=auth)
self.assertEqual(response.json()['balance'], 300) self.assertGreater(response.json()['count'], 1)
from_wallet = response.json()['results'][0]
self.assertEqual(from_wallet['balance'], 300)
params = { params = {
'uuid': self.payee_uuid, 'user': self.payee_uuid,
'wallet_uuid': self.wallet_rial_uuid,
} }
response = self.client.get(reverse('wallet:application_user_wallet_balance_api', kwargs=params), HTTP_AUTHORIZATION=auth) response = self.client.get(reverse('wallet:application_user_account_api', kwargs=params), query_params={'wallet': ','.join(wallets)}, HTTP_AUTHORIZATION=auth)
self.assertContains(response, 'balance') self.assertGreater(response.json()['count'], 1)
self.assertEqual(response.json()['balance'], 0) to_wallet = response.json()['results'][0]
self.assertEqual(to_wallet['balance'], 0)
# Deposit process # Deposit process
data = { data = {
'uuid': "b14e8b86-8f4a-44d9-b29d-badceb470053",
'amount': 200, 'amount': 200,
'payee': self.payee_uuid, 'payee': self.payee_uuid,
'payee_type': TypeChoices.USER, 'payee_type': TypeChoices.USER,
'payee_account': self.wallet_rial_uuid, 'payee_wallet': self.wallet_rial_uuid,
} }
kwargs_payer_wallet = {
kwargs_wallet_uuid_payee_uuid = { 'payer_wallet': self.wallet_rial_uuid,
'wallet_uuid': self.wallet_rial_uuid,
} }
response = self.client.post(reverse('wallet:application_deposit_submit_api', kwargs=kwargs_wallet_uuid_payee_uuid), data=data, HTTP_AUTHORIZATION=auth) response = self.client.post(reverse('wallet:application_deposit_submit_api', kwargs=kwargs_payer_wallet), data=data, HTTP_AUTHORIZATION=auth)
self.assertEqual(response.status_code, 201) self.assertEqual(response.status_code, 201)
response = self.client.post(reverse('wallet:application_deposit_submit_api', kwargs=kwargs_wallet_uuid_payee_uuid), data=data, HTTP_AUTHORIZATION=auth) response = self.client.post(reverse('wallet:application_deposit_submit_api', kwargs=kwargs_payer_wallet), data=data, HTTP_AUTHORIZATION=auth)
# self.assertEqual(response.status_code, 422) self.assertEqual(response.status_code, 422)
self.assertEqual(response.status_code, 201)
def test_withdraw_flow_success(self): def test_withdraw_flow_success(self):
auth = self._create_authorization_header(self.payer_access_token.token) auth = self._create_authorization_header(self.payer_access_token.token)

17
apps/wallet/views/application.py
View file

@ -8,6 +8,7 @@ from rest_framework.exceptions import APIException
from rest_framework.generics import get_object_or_404 from rest_framework.generics import get_object_or_404
from rest_framework.request import Request from rest_framework.request import Request
from rest_framework.response import Response from rest_framework.response import Response
import uuid
from apps.users.models import User from apps.users.models import User
from apps.wallet.constans import TypeChoices, StateChoices from apps.wallet.constans import TypeChoices, StateChoices
@ -215,26 +216,22 @@ class DepositSubmitAPIView(generics.CreateAPIView):
payee_account, _ = Account.objects.get_or_create(owner_uuid=payee_id, owner_type=payee_type, payee_account, _ = Account.objects.get_or_create(owner_uuid=payee_id, owner_type=payee_type,
wallet=payee_wallet) wallet=payee_wallet)
logger.debug(f"Payee account: {payee_account.uuid}") logger.debug(f"Payee account: {payee_account.uuid}")
uuid = serializer.validated_data.pop('uuid', None) uuid_param = serializer.validated_data.pop('uuid', uuid.uuid4()) # if uuid not provided generate new one to handle get_or_create
details = serializer.validated_data.get('details', {}) details = serializer.validated_data.get('details', {})
reference_id = details.get('reference_id', None) reference_id = details.get('reference_id', None)
logger.debug(f"Transaction UUID: {uuid}, Reference ID: {reference_id}") logger.debug(f"Transaction UUID: {uuid_param}, Reference ID: {reference_id}")
transaction_params = { transaction_params = {
'uuid': uuid_param,
'application': application, 'application': application,
'payer_account': payer_account, 'payer_account': payer_account,
'payee_account': payee_account, 'payee_account': payee_account,
'amount': serializer.validated_data.get('amount'), 'amount': serializer.validated_data.get('amount'),
} }
if uuid: # TODO: checking reference_id
transaction_params['uuid'] = uuid # if reference_id:
# transaction_params['details__reference_id'] = reference_id
if reference_id:
transaction_params['details__reference_id'] = reference_id
# else:
# logger.error('Missing UUID and Reference ID')
# raise UnprocessableEntity('Missing UUID or reference_id')
instance, created = Transaction.objects.get_or_create(**transaction_params, defaults={ instance, created = Transaction.objects.get_or_create(**transaction_params, defaults={
'details': details 'details': details
}) })