addwin/chat
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Compare commits

base: addwin:a40ce94d8c2dcd33544f91b945add9315a507c72
Branches Tags
addwin:master
..
compare: addwin:fee3a6ccb03601ac49c4aae6e55070fd7189970d
Branches Tags
addwin:master

2 commits
a40ce94d8c ... fee3a6ccb0

Author SHA1 Message Date
Ghasemi
fee3a6ccb0 Merge pull request 'fix: surface real errors when adding user to Mattermost team' (#11) from feature/debug-team-member into master 
Reviewed-on: #11
 2026-08-09 06:41:41 -04:00
Ali Asadi
e127fd39bc fix: surface real errors when adding user to Mattermost team 
_ensure_team_member silently swallowed every exception from
add_user_to_team, assuming failure meant the user was already a
member. Real failures (bad permissions, domain restrictions, wrong
team ID) were masked and only surfaced later as a confusing "No team
member found" error when adding the user to a channel. Now checks
actual membership via get_team_member and raises a clear
MattermostError on genuine add failures.
 2026-08-09 14:00:52 +03:30
1 changed files with 12 additions and 2 deletions
Show stats Expand all files Collapse all files

14
apps/chat/integrations/mattermost/client.py
View file

@ -72,12 +72,22 @@ class MattermostClient:
def _ensure_team_member(self, mm_user_id: str) -> None:
if not self._team_id:
return
try:
self._driver.teams.get_team_member(self._team_id, mm_user_id)
return # already a member
except ResourceNotFound:
pass
except Exception as exc:
raise MattermostError(f"Team membership lookup failed: {exc}") from exc
try:
self._driver.teams.add_user_to_team(
self._team_id, options={"team_id": self._team_id, "user_id": mm_user_id}
)
except Exception:
pass # already a member or team not configured — not fatal
except Exception as exc:
raise MattermostError(
f"Adding user {mm_user_id} to team failed: {exc}"
) from exc
def get_or_create_user(self, user_id: UUID) -> str:
"""