addwin/winofy-backend
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
winofy-backend/CHANGELOG.md
Ali Asadi d4254ac086 Split CartItemView so swagger stops showing broken cart endpoints 
CartItemView was registered on both /cart/items/ and
/cart/items/{item_uuid}/, so swagger listed POST/PATCH/DELETE on both
paths even though 3 of those 6 combinations raised a TypeError at
runtime (missing/unexpected item_uuid). Split into CartItemView (POST,
list path) and CartItemDetailView (PATCH/DELETE, detail path).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-08-31 12:01:38 +03:30

2.3 KiB
Raw Blame History

Changelog

[Unreleased]

Fixed

  • GET /api/v1/stores/ — documented the category, neighborhood, search, lat, and lng query params for drf-spectacular so they render in swagger. The filtering itself already worked; only the OpenAPI schema was missing them (apps/stores/views.py).
  • GET /api/v1/products/ — same issue: documented the existing store, category, and search query params for swagger (apps/catalog/views.py).
  • Cart items: CartItemView was registered on both /api/v1/cart/items/ and /api/v1/cart/items/{item_uuid}/, so swagger showed POST/PATCH/DELETE on both paths — 3 of those 6 combinations crashed with a TypeError at runtime (item_uuid missing or unexpected). Split into CartItemView (POST only, list path) and CartItemDetailView (PATCH/DELETE only, detail path) so swagger only shows the combinations that actually work (apps/orders/views.py, apps/orders/urls.py).

Added

  • GET /api/v1/cities/?search= — search cities by name (apps/locations/views.py); previously no text search existed.
  • GET /api/v1/neighborhoods/?search= — search neighborhoods by neighborhood name or city name, alongside the existing city UUID filter (apps/locations/views.py).
  • GET /api/v1/stores/ now returns phone_number in the list (previously only on the single-store detail view) and a distance_km field, populated whenever lat/lng are passed (apps/stores/serializers.py).
  • Test coverage for StoreViewSet list filtering (apps/stores/tests/test_store_list.py) — previously untested.
  • Test coverage for ProductViewSet list filtering (apps/catalog/tests/test_product_list.py) — previously untested.
  • Test coverage for CityViewSet/NeighborhoodViewSet list filtering (apps/locations/tests/test_location_list.py) — previously untested.

Changed

  • Replaced hand-rolled get_queryset filtering with django-filter FilterSet classes (apps/{stores,catalog,locations,reviews}/filters.py) and filterset_fields (apps/orders status). django-filter was already installed and set as DEFAULT_FILTER_BACKENDS but unused everywhere; params are now auto-documented in swagger by drf-spectacular's django-filter integration, so the manual OpenApiParameter declarations for those fields were removed (stores keeps lat/lng manual since geo-distance isn't a plain filter).